Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New language: Introducing Dutch for Neon #2049

Merged
merged 12 commits into from
Jan 18, 2021
Merged

Conversation

Woodehh
Copy link
Contributor

@Woodehh Woodehh commented Jan 13, 2021

What current issue(s) from Trello/Github does this address?
None

What problem does this PR solve?
The lack of the Dutch language

How did you solve this problem?
By translating and adding a Dutch flag to the ecosystem

How did you make sure your solution works?
By checking everything in line.

Are there any special changes in the code that we should be aware of?
No

Is there anything else we should know?
I had to recreate the Snapshots of the unittester by using yarn jest --updateSnapshot otherwise it wouldn't compile. Oh and Dutchies are cool.

  • Unit tests written?

@coveralls
Copy link

coveralls commented Jan 13, 2021

Pull Request Test Coverage Report for Build 7716

  • 19 of 20 (95.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 41.961%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/core/constants.js 0 1 0.0%
Totals Coverage Status
Change from base Build 7693: 0.2%
Covered Lines: 1514
Relevant Lines: 3272

💛 - Coveralls

Copy link
Member

@ixje ixje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A couple of minor typo's comments, other than that looks good 👍

Co-authored-by: Erik van den Brink <[email protected]>
@Woodehh Woodehh requested a review from ixje January 17, 2021 22:29
@comountainclimber comountainclimber merged commit eeefd3c into CityOfZion:dev Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants