-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New language: Introducing Dutch for Neon #2049
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7716
💛 - Coveralls |
ixje
requested changes
Jan 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A couple of minor typo's comments, other than that looks good 👍
Co-authored-by: Erik van den Brink <[email protected]>
Co-authored-by: Erik van den Brink <[email protected]>
Co-authored-by: Erik van den Brink <[email protected]>
Co-authored-by: Erik van den Brink <[email protected]>
Co-authored-by: Erik van den Brink <[email protected]>
Very nice, thanks. Co-authored-by: Erik van den Brink <[email protected]>
ixje
reviewed
Jan 15, 2021
Co-authored-by: Erik van den Brink <[email protected]>
comountainclimber
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) from Trello/Github does this address?
None
What problem does this PR solve?
The lack of the Dutch language
How did you solve this problem?
By translating and adding a Dutch flag to the ecosystem
How did you make sure your solution works?
By checking everything in line.
Are there any special changes in the code that we should be aware of?
No
Is there anything else we should know?
I had to recreate the Snapshots of the unittester by using
yarn jest --updateSnapshot
otherwise it wouldn't compile. Oh and Dutchies are cool.