feature: Fix potential duplicate symbol bug #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7631
💛 - Coveralls |
comountainclimber
added a commit
that referenced
this pull request
Dec 1, 2020
* feature: skip testing on tags [WIP] (#2015) * updates config.yml * Only publish on tags * Updates pack and release notes whitelist * Add back store_artifacts and remove persist to workspace * update snapshots * Updates mainnet node list * Updates ReleaseNotesModal.jsx * feature: adds dora and neotube to explorers (#2022) * Updates explorer list * Updates explorer.test.js * Updates explorer.test.js * Updates explorer.test.js * Adds back deleted test * Update content and styles in release notes modal * Updates screen shot in README (#2023) * update screen shot asset name * feature: Updates app/core/nodes-main-net.json with new coz nodes (#2025) * Updates app/core/nodes-main-net.json with new coz nodes * Increase chunk size * feature: fix balance failed "retry" load state (#2027) * Fixes translation typo and refactors FailedPanel.jsx * lint * snapshots * Revert testing changes to balancesActions.js * revert changes to AssetBalancesPanel/index.js * Updates balancesActions.js and tokenList.json (#2026) * feature: add balance fetch retry logic (#2028) * Adds RPC retry logic * small refactor in balancesActions.js * Fixes link in release notes * feature: update release notes [WIP] (#2031) * Adds release notes image asset and update release notes * Update patch.svg * Update release notes image assets
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the RPC nodes return
SWTHfor both of the following contract hashes (ab38352559b8b203bde5fddfa0b07d8b2525e132and3e09e602eeeb401a2fec8e8ea137d59aae54a139) it was breaking balance logic within neon...This PR makes it so that the hashes map back onto the symbols for the token list found here => https://github.com/CityOfZion/neo-tokens/blob/master/tokenList.json such that those symbols are reflected in the UI and the broken logic is fixed
I also went ahead an updated the hard coded list that neon uses (in the event that github is down)
TODO: before this release goes out, update the neo tokens repo