Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove panic from ModularArithmetic#Sqrt #27

Merged
merged 3 commits into from
Jan 22, 2018
Merged

Remove panic from ModularArithmetic#Sqrt #27

merged 3 commits into from
Jan 22, 2018

Conversation

revett
Copy link

@revett revett commented Jan 22, 2018

Problem

ModularArithmetic#Sqrt does not return an error but instead uses panic.

Solution

Fixed issue #23 raised by @alexanderbez.

Remember

  • Bump VERSION
  • Update CHANGELOG.md
  • Update README.md
  • Write tests

@revett revett added the Bug label Jan 22, 2018
@revett revett self-assigned this Jan 22, 2018
@revett revett merged commit 3f353b6 into master Jan 22, 2018
@revett revett deleted the bug/return-err-sqrt branch January 22, 2018 22:42
@revett revett mentioned this pull request Jan 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@revett revett

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@revett