Select Best Node #26
Merged
Select Best Node #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently you manually set a node that you wish to use for RPC calls. This is good but that node may fall behind other nodes.
Solution
Instead the package should semi-intelligently work out which nodes is the best to use out of a group from their respective block heights.
Using
neo.NewClientUsingMultipleNodes()allows for this.It will call each node and select the one with highest block height. At any point,
client. SelectBestNode()can be called to repeat this process.This has been added to the tests to make them more reliable.
Remember
VERSIONCHANGELOG.mdREADME.md