CU-86a0dn0k3 - Ethereum Support Implementation #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: CU-86a0dn0k3 Ethereum Support Implementation |
| if (!result.data) throw new Error('Balance not found') | ||
|
|
||
| const balances = result.data.ethereum.address[0].balances.map( | ||
| (balance): BalanceResponse => ({ |
There was a problem hiding this comment.
nitpick: see comment above about destructuring for slightly improved readability
There was a problem hiding this comment.
tbh I prefer the old way, but whatever, let's move on
melanke
reviewed
Aug 29, 2023
raulduartep
force-pushed
the
CU-86a0dn0k3
branch
from
b4a8486 to
3f18764
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.