Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a filter for zipcode. #417

Merged
merged 6 commits into from
Aug 19, 2021
Merged

Add a filter for zipcode. #417

merged 6 commits into from
Aug 19, 2021

Conversation

willrlin
Copy link

@willrlin willrlin commented Aug 18, 2021 •
edited
Loading

Pull Request Template

Issue

Closes #321

Description

Adds a text field on the frontend that filters listings by zip code.

Type of change

  • New feature (non-breaking change which adds functionality)

How Can This Be Tested/Reviewed?

Reseed the database and type in one or more comma separated zip codes.

  • Desktop View
  • Mobile View

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes

anders-schneider
anders-schneider reviewed Aug 18, 2021
View reviewed changes
Copy link

@anders-schneider anders-schneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly questions about validation (below)

anders-schneider
anders-schneider approved these changes Aug 19, 2021
View reviewed changes
Copy link

@anders-schneider anders-schneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those explanations!

@willrlin willrlin merged commit 2a9db91 into main Aug 19, 2021
@willrlin willrlin deleted the 321/zipcode-filter branch August 19, 2021 18:07
seanmalbert pushed a commit that referenced this pull request Jun 23, 2022
@willrlin
Add a filter for zipcode. (#417)
a8741c7 
* Working filters, but validation doesn't show error message.

* Add in translations for new strings.

* Edit CHANGELOG.

* Change the validation to use a method.

* Remove debugging console logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anders-schneider anders-schneider anders-schneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zip Code Filter
2 participants
@willrlin @anders-schneider