Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CSV listing import script #404

Merged
merged 18 commits into from
Aug 17, 2021

Conversation

anders-schneider
Copy link

@anders-schneider anders-schneider commented Aug 13, 2021

Issue

Addresses #227

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

This change adds a CSV listing import script, and it is intended to be used specifically for the data in the HRD listing spreadsheet. It reuses the existing listings-importer.ts library. (Aside: the listings-importer.ts library has a bug, and this change does not attempt to fix that bug - that work is happening separately.)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

I tested this by running the script, and checking that each of the fields that should have been populated were in fact populated correctly in the DB.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes

@anders-schneider anders-schneider changed the title Aeschneider/add csv import script Add a CSV listing import script Aug 16, 2021
@anders-schneider anders-schneider marked this pull request as ready for review August 16, 2021 20:45
@anders-schneider anders-schneider merged commit ef8e9cb into main Aug 17, 2021
@anders-schneider anders-schneider deleted the aeschneider/add-csv-import-script branch August 17, 2021 16:32
seanmalbert pushed a commit that referenced this pull request Jun 23, 2022
* initial commit just to record early changes

* Maybe working version of the script

* Updates to make the script work

* Handle synchronization

* Pass errors through listings-importer library

* Remove fiveBdrm nonsense

* revert fivebdrm changes

* Improvements, but blocked on double-property creation

* Add a couple clarifying comments

* Add a top-level comment

* Added to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants