Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Addresses #227
Description
This change adds a number of fields to the
Listing
andProperty
models, corresponding to fields we have in the Detroit listing spreadsheet but that don't yet exist in the Bloom data model.#227 (comment) has a full breakdown of how we plan to map the Detroit spreadsheet fields to Bloom data model fields. This change adds all the fields that are indicated by an asterisk (since they did not yet exist in Bloom).
Most of these fields are likely relatively uncontroversial. The most "controversial" additions are
amiPercentageMin
andamiPercentageMax
. In the existing Bloom data model, AMI percentage information is stored at the level of an individual unit, and soon it will be part of the "UnitsSummarized" table. This change adds a separate option: store AMI percentage information at the level of an entire listing. To date, the Detroit data only includes AMI percentage information at the level of an entire listing, so these fields are necessary. As noted in the code comment, though, we'll rely primarily on the unit-level AMI percentage information and only use the listing-level AMI percentage range if the unit-level data is absent.Type of change
How Can This Be Tested/Reviewed?
Applying the generated DB migration is successful, and the
backend/core
tests pass.Checklist: