Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partners summary form #300

Merged
merged 6 commits into from
Aug 2, 2021
Merged

Partners summary form #300

merged 6 commits into from
Aug 2, 2021

Conversation

abbiefarr
Copy link

@abbiefarr abbiefarr commented Jul 30, 2021 •
edited
Loading

Pull Request Template

Issue

#298

Addresses # (issue)

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

When a partner goes to edit a listing, they can toggle between a "Unit Types" and "Individual Units" view. "Individual Units" shows all their units and allows them to add, remove, or edit units. "Unit Types" shows a summary table based on unit type.

image

image

NOTE: This is not a complete feature. Editing the summary table is not possible.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

In the partner portal, edit a listing and toggle between "Unit Types" and "Individual Units"

  • Desktop View
  • Mobile View

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes

@abbiefarr abbiefarr added the epic: partner portal Tickets related to the partner portal label Jul 30, 2021
@abbiefarr abbiefarr added this to the M9 milestone Jul 30, 2021
@abbiefarr abbiefarr requested a review from willrlin July 30, 2021 19:23
@abbiefarr
Copy link
Author

I wasn't planning on submitting this, I thought I could send screenshots to Safiya that she could show during the property manager meeting. But still wanted to get some eyes on it, I can submit if you think it's useful.

@abbiefarr abbiefarr linked an issue Aug 2, 2021 that may be closed by this pull request
Units summary view in listing edit form mock #298
Closed
@abbiefarr
Copy link
Author

There's a bug in the non-admin property listing page that causes this feature to not work for non-admins. I'll file a ticket for that soon.

@abbiefarr abbiefarr merged commit bb98ebb into main Aug 2, 2021
@abbiefarr abbiefarr deleted the partners-summary-form branch August 2, 2021 16:58
seanmalbert pushed a commit that referenced this pull request Jun 23, 2022
@abbiefarr @lint-action
Partners summary form (#300)
8ccc19e 
* field group callback

* toggle unit summary table

* Fix code style issues with Prettier

Co-authored-by: Lint Action <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willrlin willrlin willrlin approved these changes

Assignees
No one assigned
Labels
epic: partner portal Tickets related to the partner portal
Projects
None yet
Milestone
M9
Development

Successfully merging this pull request may close these issues.

Units summary view in listing edit form mock
3 participants
@abbiefarr @willrlin @lint-action