Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the pre-generated pagination. #140

Merged
merged 4 commits into from
Jul 14, 2021
Merged

Remove the pre-generated pagination. #140

merged 4 commits into from
Jul 14, 2021

Conversation

willrlin
Copy link

@willrlin willrlin commented Jul 2, 2021 •
edited
Loading

Issue

Addresses #54

  • This change addresses only certain aspects of the issue

Description

I had the incorrect type on the axios response, which led to the
metadata being undefined, so no pages were being generated.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes

@willrlin
Fix the metadata from the axios response.
6d9d749 
I had the incorrect type on the axios response, which led to the
metadata being undefined, so no pages were being generated.
@willrlin willrlin requested a review from avaleske July 2, 2021 20:41
avaleske
avaleske reviewed Jul 2, 2021
View reviewed changes
Copy link

@avaleske avaleske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but there's an issue with Array.from

@willrlin willrlin requested a review from avaleske July 13, 2021 01:19
avaleske
avaleske approved these changes Jul 13, 2021
View reviewed changes
Copy link

@avaleske avaleske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this doesn't close the related issue when you merge this.

Also should we just delete these pages instead, since this isn't how pagination is going to work?

@willrlin willrlin changed the title Fix the metadata from the axios response. Remove the pre-generated pagination. Jul 14, 2021
@willrlin
Copy link
Author

Make sure this doesn't close the related issue when you merge this.

Also should we just delete these pages instead, since this isn't how pagination is going to work?

Done! And the related issue is already closed now.

@willrlin willrlin linked an issue Jul 14, 2021 that may be closed by this pull request
Add pagination to listings component #54
Closed
2 tasks
@willrlin willrlin merged commit da37dda into main Jul 14, 2021
@willrlin willrlin deleted the pagination/hardcode-frontend branch July 14, 2021 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avaleske avaleske avaleske approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pagination to listings component
2 participants
@willrlin @avaleske