Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1165/design items #1270

Merged
merged 9 commits into from
May 23, 2022
5 changes: 4 additions & 1 deletion sites/public/pages/listing/[id]/[slug].tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { useEffect, useContext } from "react"
import Head from "next/head"
import axios from "axios"
import { Listing } from "@bloom-housing/backend-core/types"
import { AuthContext, t } from "@bloom-housing/ui-components"
import { AuthContext, ListingDividerLine, t } from "@bloom-housing/ui-components"
import { imageUrlFromListing, ListingDetail, pushGtmEvent } from "@bloom-housing/shared-helpers"
import { UserStatus } from "../../../lib/constants"
import Layout from "../../../layouts/application"
Expand Down Expand Up @@ -63,6 +63,9 @@ export default function ListingPage(props: ListingProps) {
<title>{pageTitle}</title>
</Head>
<MetaTags title={listing.name} image={metaImage} description={metaDescription} />
<span className="hidden md:block">
<ListingDividerLine />
</span>
<ListingView listing={listing} allowFavoriting={true} />
</Layout>
)
Expand Down
2 changes: 1 addition & 1 deletion sites/public/src/ListingView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export const ListingProcess = (props: ListingProcessProps) => {
} = props

return (
<aside className="w-full static md:me-8 md:ms-2 md:border border-gray-400 bg-white text-gray-750">
<aside className="w-full static md:me-8 md:ms-2 md:border-r md:border-l md:border-b border-gray-400 bg-white text-gray-750">
<ListingUpdated listingUpdated={listing.updatedAt} />
{openHouseEvents && <OpenHouseEvent events={openHouseEvents} />}
{!applicationsClosed && (
Expand Down
2 changes: 2 additions & 0 deletions sites/public/styles/footers.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ footer.site-footer > .footer-row:first-of-type {

.footer-sections {
padding: 2rem 0;
max-width: 1024px;
margin: auto;
}

.footer-sock {
Expand Down
1 change: 0 additions & 1 deletion sites/public/styles/headers.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
.navbar {
align-items: center;
height: auto;
justify-content: flex-start;
max-height: none;
padding: 24px 0 18px;

Expand Down
1 change: 1 addition & 0 deletions ui-components/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ export * from "./src/page_components/listing/ContentAccordion"
export * from "./src/page_components/listing/ListingCard"
export * from "./src/page_components/listing/ListingDetailHeader"
export * from "./src/page_components/listing/ListingDetails"
export * from "./src/page_components/listing/ListingDividerLine"
export * from "./src/page_components/listing/ListingMap"
export * from "./src/page_components/listing/ListingsGroup"
export * from "./src/page_components/listing/UnitTables"
Expand Down
2 changes: 1 addition & 1 deletion ui-components/src/blocks/Tooltip.scss
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ $tooltip_arrow_height: 9px;
@apply w-0 h-0;
@apply border-solid;
@apply left-1/2;
bottom: -$tooltip_arrow_height;
bottom: -$tooltip_padding;
transform: translateX(-50%);
border-width: $tooltip_arrow_height 7px 0 7px;
border-color: theme("colors.primary-dark") transparent transparent transparent;
Expand Down
2 changes: 1 addition & 1 deletion ui-components/src/footers/SiteFooter.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ footer.site-footer {
}

p {
@apply mb-5;
@apply mb-8;
}

& > .footer-row:first-of-type {
Expand Down
10 changes: 9 additions & 1 deletion ui-components/src/navigation/LanguageNav.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,18 @@
}

.language-bar__inner {
@apply max-w-5xl;
@apply w-full;
@apply flex;
@apply justify-end;
margin: auto;

@screen md {
padding: 0 12px;
}

@screen lg {
padding: 0 50px;
}
}

.language-nav__list {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import * as React from "react"

const ListingDividerLine = () => {
return <section className="w-full border-b border-gray-400 h-0"></section>
}

export { ListingDividerLine as default, ListingDividerLine }
1 change: 0 additions & 1 deletion ui-components/src/sections/FooterSection.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.footer-row__section {
@apply max-w-5xl;
@apply m-auto;
@apply px-2;
@apply text-center;
Expand Down