This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
New folder structure #934
Merged
New folder structure #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack configs to support having both old and new folder structure side by side.
Codecov Report
@@ Coverage Diff @@
## develop #934 +/- ##
===========================================
+ Coverage 91.77% 92.03% +0.25%
===========================================
Files 220 218 -2
Lines 2869 2861 -8
Branches 505 504 -1
===========================================
Hits 2633 2633
+ Misses 208 201 -7
+ Partials 28 27 -1Continue to review full report at Codecov.
|
jimppa
reviewed
May 23, 2019
| @@ -0,0 +1,41 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Seems like this file was copied instead of moved since app/routes.js still exists, maybe delete that.
There was a problem hiding this comment.
ah, good point. I'll fix that!
Nizar-Rahme
approved these changes
May 23, 2019
jimppa
approved these changes
May 23, 2019
midori0507
approved these changes
May 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base for the new folder structure. The idea is that now we can start gradually moving into the new folder structure.