Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

VAR-57 | Add slot_size and minPeriod to reservation select #925

Merged
merged 21 commits into from
May 9, 2019

Conversation

midori0507
Copy link

@midori0507 midori0507 commented May 3, 2019

  • Refactor Timeslot reducer / functionalities.
  • User now only able to clear the selection from clicking the clear button
  • Add various unit tests / time utils.
  • Populate time slot when select with minPeriod if resource minPeriod exist
  • Add info about min period on resource page

@codecov-io
Copy link

codecov-io commented May 3, 2019

Codecov Report

Merging #925 into develop will increase coverage by 0.15%.
The diff coverage is 95.45%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #925      +/-   ##
===========================================
+ Coverage    91.61%   91.77%   +0.15%     
===========================================
  Files          217      217              
  Lines         2828     2846      +18     
  Branches       496      499       +3     
===========================================
+ Hits          2591     2612      +21     
+ Misses         208      207       -1     
+ Partials        29       27       -2
Impacted Files Coverage Δ
app/shared/form-fields/ReservationTimeControls.js 100% <ø> (ø) ⬆️
app/utils/fixtures/Resource.js 100% <ø> (ø) ⬆️
...red/modals/reservation-info/ReservationEditForm.js 97.56% <ø> (ø) ⬆️
...servation-controls/ReservationControlsContainer.js 69.23% <100%> (ø) ⬆️
...eservation-calendar/reservationCalendarSelector.js 100% <100%> (ø) ⬆️
...ource/reservation-calendar/time-slots/TimeSlots.js 86.58% <100%> (+4.65%) ⬆️
app/utils/resourceUtils.js 99% <100%> (+0.05%) ⬆️
app/state/reducers/ui/reservationsReducer.js 91.66% <100%> (+1.28%) ⬆️
app/utils/timeUtils.js 100% <100%> (ø) ⬆️
app/constants/SlotConstants.js 100% <100%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9efbaff...0a5e5e1. Read the comment docs.

@midori0507 midori0507 requested a review from Nizar-Rahme May 8, 2019 13:26
@midori0507 midori0507 changed the title [WIP] slot_size VAR-57 | Add slot_size and minPeriod to reservation select May 8, 2019
@midori0507 midori0507 self-assigned this May 8, 2019
@midori0507 midori0507 requested a review from jimppa May 8, 2019 13:36
@midori0507 midori0507 merged commit 5aadc01 into develop May 9, 2019
@midori0507 midori0507 deleted the feature/VAR-57 branch May 9, 2019 08:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants