This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
VAR-49 | Add municipality options to env config. #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midori0507
commented
Apr 29, 2019
midori0507
commented
- Add ability to add custom municiple to .env
- Add safety check for non-string value and non-array.
- Add unit tests.
- Default options is central cities.
Codecov Report
@@ Coverage Diff @@
## develop #922 +/- ##
===========================================
+ Coverage 91.6% 91.61% +0.01%
===========================================
Files 217 217
Lines 2823 2828 +5
Branches 494 496 +2
===========================================
+ Hits 2586 2591 +5
Misses 208 208
Partials 29 29
Continue to review full report at Codecov.
|
rBoost
approved these changes
Apr 30, 2019
rBoost
suggested changes
Apr 30, 2019
README.md
Outdated
| Custom config to replace global application's api URL. Expected value is valid URL string. | ||
|
|
||
| - `CUSTOM_MUNICIPALITY_OPTIONS`: | ||
| Config for custom municipalities. Expected value is array of municipalities: `['example_city']`. |
There was a problem hiding this comment.
I don't think anyone wants to add cities with _ :)
rBoost
approved these changes
Apr 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.