Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Clean up obsolete/deprecated component. #900

Merged
merged 3 commits into from
Mar 21, 2019
Merged

Conversation

midori0507
Copy link

@midori0507 midori0507 commented Mar 20, 2019

  • Delete navbar, sidebar, side-navbar which was replaced by new component but not getting removed after that. They're not getting imported anywhere in the code also.
  • Bonus: small tweak for label coloring so text can be easier to see

@midori0507 midori0507 requested review from Rasbin and rBoost March 20, 2019 10:36
@codecov-io
Copy link

codecov-io commented Mar 20, 2019

Codecov Report

Merging #900 into develop will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #900      +/-   ##
===========================================
+ Coverage    91.63%   91.67%   +0.04%     
===========================================
  Files          218      213       -5     
  Lines         2846     2800      -46     
  Branches       501      493       -8     
===========================================
- Hits          2608     2567      -41     
+ Misses         210      205       -5     
  Partials        28       28
Impacted Files Coverage Δ
app/shared/top-navbar/TopNavbar.js 50% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53869e3...003a90d. Read the comment docs.

@midori0507 midori0507 merged commit 23b6ba3 into develop Mar 21, 2019
@midori0507 midori0507 deleted the feature/cleanup branch March 21, 2019 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants