Remove unnecessary outdated dependencies #892
Conversation
| test('renders DocumentTitle component', () => { | ||
| const title = getWrapper().find(DocumentTitle); | ||
| expect(title.prop('title')).toBe('Test title - Varaamo'); | ||
| test('renders Helmet title', () => { |
There was a problem hiding this comment.
as Helmet is not easily render a component which have prop, have to use mount instead of shallow rendering.
The code below did the same thing needed to test
Codecov Report
@@ Coverage Diff @@
## develop #892 +/- ##
========================================
Coverage 91.51% 91.51%
========================================
Files 217 217
Lines 2828 2828
Branches 498 498
========================================
Hits 2588 2588
Misses 212 212
Partials 28 28
Continue to review full report at Codecov.
|
midori0507
force-pushed
the
feature/remove-react-title-use-helmet
branch
from
436c1a9 to
ce74a7d
Compare
| </div> | ||
| </DocumentTitle> | ||
| </BodyClassName> | ||
| <div className={classNames('app', getCustomizationClassName())}> |
There was a problem hiding this comment.
Are you 100% sure this is enough, because if there are any styles that depend on body class name then this most likely doesn't work?
There was a problem hiding this comment.
We just have to be 100% sure that Vantaa/Espoo site styles work like they use to work.
There was a problem hiding this comment.
@rBoost: I tested it under Espoo/Vantaa varaamo.vantaa.fi, remove the class from body and move the classname to app, everything still work after that
This is only for css usage
react-document-title, usereact-helmetreact-body-classname, classname append can be handled byclassnames