Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Replace Chai with Jest's assertions #890

Merged
merged 3 commits into from
Mar 11, 2019

Conversation

Nizar-Rahme
Copy link
Contributor

No description provided.

@Nizar-Rahme Nizar-Rahme self-assigned this Mar 11, 2019
@Nizar-Rahme Nizar-Rahme changed the title Replace chai with jest's assertions Replace Chai with Jest's assertions Mar 11, 2019
@Nizar-Rahme
Copy link
Contributor Author

@codecov-io
Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #890 into develop will increase coverage by 0.17%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #890      +/-   ##
=========================================
+ Coverage    90.83%    91%   +0.17%     
=========================================
  Files          217    217              
  Lines         2825   2825              
  Branches       497    497              
=========================================
+ Hits          2566   2571       +5     
+ Misses         226    223       -3     
+ Partials        33     31       -2
Impacted Files Coverage Δ
app/utils/__tests__/customizationUtils.js 0% <0%> (ø) ⬆️
app/utils/testUtils.js 88.23% <77.77%> (ø) ⬆️
app/shared/side-navbar/SideNavbar.js 93.33% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f49bcf4...5b5142b. Read the comment docs.

@midori0507 midori0507 self-requested a review March 11, 2019 14:38
Copy link

@midori0507 midori0507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage stay same or increase so no extra line was added, all just test syntax changes 👍

@Nizar-Rahme Nizar-Rahme force-pushed the fix/replace-chai-with-jest-assertion branch from 5b5142b to 336324e Compare March 11, 2019 14:41
@midori0507 midori0507 merged commit 1bc2510 into develop Mar 11, 2019
@midori0507 midori0507 deleted the fix/replace-chai-with-jest-assertion branch March 11, 2019 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants