This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
VAR-325 | Change createIsStaffSelector to respect manager role #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The createIsStaffSelector will now build a selector that will return true when the user has the unit manager role for the resource given as a parameter. The manager and admin roles should, at least for now, have the exact same permission within this UI. As the permission system is not centralized anywhere else, this selector is the easiest place in the code to synchronize these permissions.
Jokinen
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1118 +/- ##
===========================================
+ Coverage 74.44% 74.49% +0.04%
===========================================
Files 260 260
Lines 4136 4144 +8
Branches 704 706 +2
===========================================
+ Hits 3079 3087 +8
Misses 902 902
Partials 155 155
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The createIsStaffSelector will now build a selector that will return
true when the user has the unit manager role for the resource given as
a parameter.
The manager and admin roles should, at least for now, have the exact
same permission within this UI. As the permission system is not
centralized anywhere else, this selector is the easiest place in the
code to synchronize these permissions.