Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

VAR - 257 | Reorder and combine blocks #1083

Merged
merged 5 commits into from
Dec 3, 2019

Conversation

tuovinensanttu
Copy link
Contributor

Reordered info blocks on ResourcePage. Moved min period from "Reserve" to "Reservation information".

@tuovinensanttu tuovinensanttu added this to the 0.8.0 milestone Dec 3, 2019
@tuovinensanttu tuovinensanttu self-assigned this Dec 3, 2019
@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #1083 into develop will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1083      +/-   ##
===========================================
- Coverage    74.09%   74.06%   -0.04%     
===========================================
  Files          245      245              
  Lines         3590     3593       +3     
  Branches       644      646       +2     
===========================================
+ Hits          2660     2661       +1     
- Misses         796      798       +2     
  Partials       134      134
Impacted Files Coverage Δ
app/pages/resource/ResourcePage.js 76% <ø> (-0.93%) ⬇️
app/pages/resource/resource-info/ResourceInfo.js 100% <ø> (ø) ⬆️
...pages/resource/reservation-info/ReservationInfo.js 90.47% <66.66%> (-9.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe1d22d...31f6f82. Read the comment docs.

Copy link
Contributor

@ironroger ironroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes.

@tuovinensanttu tuovinensanttu merged commit 3fa478f into develop Dec 3, 2019
@tuovinensanttu tuovinensanttu deleted the feature/var-257-re-order-and-combine-blocks branch December 3, 2019 08:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants