Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Bug/var 223 notifications missing #1062

Merged
merged 11 commits into from
Nov 12, 2019
Merged

Conversation

ironroger
Copy link
Contributor

Old notifications are reverted back to app folder.

@codecov-io
Copy link

codecov-io commented Nov 12, 2019

Codecov Report

Merging #1062 into develop will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1062      +/-   ##
===========================================
- Coverage       75%   74.92%   -0.08%     
===========================================
  Files          238      241       +3     
  Lines         3424     3462      +38     
  Branches       622      629       +7     
===========================================
+ Hits          2568     2594      +26     
- Misses         731      741      +10     
- Partials       125      127       +2
Impacted Files Coverage Δ
...es/reservation/reservation-time/ReservationTime.js 76.92% <ø> (ø) ⬆️
app/pages/AppContainer.js 94.11% <ø> (ø) ⬆️
app/pages/resource/ResourcePage.js 76.92% <ø> (ø) ⬆️
app/pages/reservation/ReservationPage.js 85.33% <ø> (ø) ⬆️
src/common/api/client.js 54.54% <0%> (-9.75%) ⬇️
app/actions/notificationsActions.js 100% <100%> (ø)
app/shared/notifications/NotificationsContainer.js 71.42% <71.42%> (ø)
app/state/reducers/notificationsReducer.js 79.16% <79.16%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5ab967...eb4b2a3. Read the comment docs.

Copy link
Contributor

@tuovinensanttu tuovinensanttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All notifications mentioned in ticket tested. They are working OK.

@ironroger ironroger merged commit 41447bc into develop Nov 12, 2019
@ironroger ironroger deleted the bug/VAR-223-notifications-missing branch November 12, 2019 09:55
@tuovinensanttu tuovinensanttu added this to the 0.7.0 milestone Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants