Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

VAR-209 | Show errors to staff members if editing of reservations fail #1033

Merged
merged 2 commits into from
Oct 2, 2019

Conversation

badrange
Copy link

@badrange badrange commented Oct 2, 2019

Before this errors from Respa got swallowed and try-catch would not catch any errors.

@badrange badrange requested a review from midori0507 October 2, 2019 09:02
@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #1033 into develop will decrease coverage by 0.1%.
The diff coverage is 8.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1033      +/-   ##
===========================================
- Coverage    76.71%   76.61%   -0.11%     
===========================================
  Files          240      240              
  Lines         3423     3429       +6     
  Branches       619      619              
===========================================
+ Hits          2626     2627       +1     
- Misses         690      695       +5     
  Partials       107      107
Impacted Files Coverage Δ
.../reservation/manage/page/ManageReservationsPage.js 36.66% <0%> (-2.62%) ⬇️
src/common/api/client.js 85.71% <33.33%> (-3.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d92fe...b065982. Read the comment docs.

@midori0507 midori0507 self-assigned this Oct 2, 2019
@midori0507 midori0507 added this to the 0.6.0 milestone Oct 2, 2019
@midori0507 midori0507 assigned badrange and unassigned midori0507 Oct 2, 2019
@badrange badrange merged commit 87ba987 into develop Oct 2, 2019
@midori0507 midori0507 deleted the feature/VAR-209-improve-error-handling branch October 2, 2019 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants