Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

VAR-183 | Better max period handling for FullCalendar #1032

Merged
merged 7 commits into from
Oct 1, 2019

Conversation

midori0507
Copy link

@midori0507 midori0507 commented Oct 1, 2019

  • User able to select / resize timeslot as much as they want.

  • When resized or selected time slots is smaller than min_period -> display notification, auto-select min_period amount of slots.

  • When resized or selected time slots which is bigger than max_period -> display notification, auto-select amout of max_period only

  • add selectMirror to make selection feeling same with google calendar

@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #1032 into develop will decrease coverage by 0.41%.
The diff coverage is 60.49%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1032      +/-   ##
===========================================
- Coverage    77.13%   76.71%   -0.42%     
===========================================
  Files          240      240              
  Lines         3385     3423      +38     
  Branches       614      619       +5     
===========================================
+ Hits          2611     2626      +15     
- Misses         671      690      +19     
- Partials       103      107       +4
Impacted Files Coverage Δ
src/domain/resource/utils.js 68.77% <100%> (-2.77%) ⬇️
src/common/calendar/TimePickerCalendar.js 27.08% <20.51%> (-9.76%) ⬇️
src/common/calendar/utils.js 97.67% <97.56%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b12e128...d5f8b90. Read the comment docs.

@midori0507 midori0507 requested a review from jimppa October 1, 2019 13:08
@midori0507 midori0507 added the bug label Oct 1, 2019
@midori0507 midori0507 added this to the 0.6.0 milestone Oct 1, 2019
@midori0507 midori0507 requested a review from jimppa October 1, 2019 13:21
Copy link
Contributor

@jimppa jimppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@midori0507 midori0507 merged commit a5d92fe into develop Oct 1, 2019
@midori0507 midori0507 deleted the feature/VAR-183 branch October 1, 2019 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants