This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 22
VAR-183 | Better max period handling for FullCalendar #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t resizing, add translations for infos
Codecov Report
@@ Coverage Diff @@
## develop #1032 +/- ##
===========================================
- Coverage 77.13% 76.71% -0.42%
===========================================
Files 240 240
Lines 3385 3423 +38
Branches 614 619 +5
===========================================
+ Hits 2611 2626 +15
- Misses 671 690 +19
- Partials 103 107 +4
Continue to review full report at Codecov.
|
jimppa
reviewed
Oct 1, 2019
jimppa
reviewed
Oct 1, 2019
jimppa
approved these changes
Oct 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User able to select / resize timeslot as much as they want.
When resized or selected time slots is smaller than min_period -> display notification, auto-select min_period amount of slots.
When resized or selected time slots which is bigger than max_period -> display notification, auto-select amout of max_period only
add
selectMirror
to make selection feeling same with google calendar