Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

VAR-163 | Manage reservation filter buttons #1006

Merged
merged 7 commits into from
Sep 16, 2019

Conversation

midori0507
Copy link

@midori0507 midori0507 commented Sep 16, 2019

  1. Add show only filter section, to filter reservation list.
  2. Add show by can_modify permission button
  3. Add show by favorite button. Check user's favorite resources and filter list base on that.

MINOR:

  1. Fix 1px glitch on manage-reservaion input box.
  2. Use favorite instead of favourite (US instead of UK)

@midori0507 midori0507 added this to the 0.6.0 milestone Sep 16, 2019
@midori0507 midori0507 self-assigned this Sep 16, 2019
@codecov-io
Copy link

codecov-io commented Sep 16, 2019

Codecov Report

Merging #1006 into develop will decrease coverage by 0.26%.
The diff coverage is 19.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1006      +/-   ##
===========================================
- Coverage    78.28%   78.01%   -0.27%     
===========================================
  Files          248      248              
  Lines         3665     3684      +19     
  Branches       663      669       +6     
===========================================
+ Hits          2869     2874       +5     
- Misses         694      702       +8     
- Partials       102      108       +6
Impacted Files Coverage Δ
src/domain/reservation/constants.js 100% <100%> (ø) ⬆️
...vation/manage/filters/ManageReservationsFilters.js 50% <33.33%> (+2%) ⬆️
.../reservation/manage/page/ManageReservationsPage.js 20.37% <5.88%> (-4.02%) ⬇️
app/state/selectors/dataSelectors.js 87.5% <50%> (-12.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a0949e...7f03ab2. Read the comment docs.

@midori0507 midori0507 requested a review from jimppa September 16, 2019 11:38
@midori0507 midori0507 merged commit f8de554 into develop Sep 16, 2019
@midori0507 midori0507 deleted the feature/VAR-186-favourite-filter branch September 16, 2019 11:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants