This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 22
VAR-181 | Reservation information modal is missing metadata fields #1005
Merged
midori0507
merged 6 commits into
develop
from
fix/VAR-181-reservation-information-metadata-fields
Sep 13, 2019
Merged
VAR-181 | Reservation information modal is missing metadata fields #1005
midori0507
merged 6 commits into
develop
from
fix/VAR-181-reservation-information-metadata-fields
Sep 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midori0507
commented
Sep 12, 2019
- Dynamically render reservation metadata fields.
- Add custom function to render custom metadata rows.
- Add supported fields (extract from Respa)
- Trim empty field value, hide those field from rendering.
- Hide reservation action button from user without permissions in manage reservation.
midori0507
changed the title
VAR-181 | Reservation information metadata fields
VAR-181 | Reservation information modal is missing metadata fields
Sep 12, 2019
Codecov Report
@@ Coverage Diff @@
## develop #1005 +/- ##
===========================================
+ Coverage 78.23% 78.28% +0.04%
===========================================
Files 246 248 +2
Lines 3658 3665 +7
Branches 662 663 +1
===========================================
+ Hits 2862 2869 +7
- Misses 693 694 +1
+ Partials 103 102 -1
Continue to review full report at Codecov.
|
Nizar-Rahme
suggested changes
Sep 12, 2019
Nizar-Rahme
suggested changes
Sep 13, 2019
Nizar-Rahme
approved these changes
Sep 13, 2019
midori0507
deleted the
fix/VAR-181-reservation-information-metadata-fields
branch
September 13, 2019 08:26
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.