Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

VAR-181 | Reservation information modal is missing metadata fields #1005

Merged

Conversation

midori0507
Copy link

  • Dynamically render reservation metadata fields.
  • Add custom function to render custom metadata rows.
  • Add supported fields (extract from Respa)
  • Trim empty field value, hide those field from rendering.
  • Hide reservation action button from user without permissions in manage reservation.

@midori0507 midori0507 self-assigned this Sep 12, 2019
@midori0507 midori0507 added this to the 0.6.0 milestone Sep 12, 2019
@midori0507 midori0507 requested a review from badrange September 12, 2019 13:39
@midori0507 midori0507 changed the title VAR-181 | Reservation information metadata fields VAR-181 | Reservation information modal is missing metadata fields Sep 12, 2019
@codecov-io
Copy link

codecov-io commented Sep 12, 2019

Codecov Report

Merging #1005 into develop will increase coverage by 0.04%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1005      +/-   ##
===========================================
+ Coverage    78.23%   78.28%   +0.04%     
===========================================
  Files          246      248       +2     
  Lines         3658     3665       +7     
  Branches       662      663       +1     
===========================================
+ Hits          2862     2869       +7     
- Misses         693      694       +1     
+ Partials       103      102       -1
Impacted Files Coverage Δ
...n/reservation/modal/ReservationInformationModal.js 58.33% <0%> (-5.96%) ⬇️
...vation/manage/action/ManageReservationsDropdown.js 50% <0%> (ø) ⬆️
src/domain/reservation/constants.js 100% <100%> (ø)
...ain/reservation/information/ReservationMetadata.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 013bd6d...8b1975a. Read the comment docs.

CHANGELOG.md Show resolved Hide resolved
src/domain/reservation/information/ReservationMetadata.js Outdated Show resolved Hide resolved
@midori0507 midori0507 merged commit 2a0949e into develop Sep 13, 2019
@midori0507 midori0507 deleted the fix/VAR-181-reservation-information-metadata-fields branch September 13, 2019 08:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants