Update permit renewal end time calculation #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the open ended permit renewal process permit end time calculation. Calculate the end time by adding `months` to the start time. Also update DST-testcases and add more tests for edge cases.
Also update test.
Add id to RefundAdmin list. Remove custom ordering from ParkingPermitAdmin. This way latest permits become first in the list, which is typically more desirable use-case.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the open ended permit renewal process permit end time calculation. Calculate the end time by adding
monthsto the start time.Other updates:
Context
PV-908
How Has This Been Tested?
Through enhanced unit tests.