fix open ended permit end time calculation. #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnttiRae
force-pushed
the
PV-852-open-ended-permit-end-time-calucation-issue
branch
from
d5d81cc to
2fa4396
Compare
AnttiRae
force-pushed
the
PV-852-open-ended-permit-end-time-calucation-issue
branch
from
2fa4396 to
9d17f0a
Compare
AnttiRae
force-pushed
the
PV-852-open-ended-permit-end-time-calucation-issue
branch
from
9d17f0a to
127e2cc
Compare
ParkingPermit end_time was wrong after renewal in some cases when incrementing end time by a month. refs: PV-852
AnttiRae
force-pushed
the
PV-852-open-ended-permit-end-time-calucation-issue
branch
from
127e2cc to
2a7ca14
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ParkingPermit end_time was wrong after renewal in some cases when incrementing end time by a month.
In cases where a permit's
end_timewas set to end of a month the end would shift down (for example after a month with 28 days). This PR fixes this so that the permits end day for next month gets set back to the originalend_time's day if possible. For example end times could look like this with renewals: 31.1 -> 28.2 -> 31.3.Context
PV-852
How Has This Been Tested?
New tests to make sure changes work as excepted.