Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PERMIT_EXTENSIONS_ENABLED flag to allow extending permits #481

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

danjacob-anders
Copy link
Contributor

@danjacob-anders danjacob-anders commented Feb 15, 2024

Description

Adds an environment variable PERMIT_EXTENSIONS_ENABLED which disables this feature by default.

Context

PV-794

How Has This Been Tested?

Unit and manually tested

Manual Testing Instructions for Reviewers

Webshop will no longer show "extend permit" button.

Set PERMIT_EXTENSIONS_ENABLED=true in local env to re-enable.

Copy link

Copy link
Collaborator

@mhieta mhieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f4c68d) 84.57% compared to head (1dbdf95) 84.59%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #481      +/-   ##
===========================================
+ Coverage    84.57%   84.59%   +0.02%     
===========================================
  Files          166      166              
  Lines        10209    10227      +18     
===========================================
+ Hits          8634     8652      +18     
  Misses        1575     1575              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhieta mhieta merged commit c0b1a26 into develop Feb 15, 2024
3 checks passed
@mhieta mhieta deleted the PV-794-permit-extensions-flag branch February 15, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants