Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark permit as cancelled after 15 minutes of order creation #472

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

mhieta
Copy link
Collaborator

@mhieta mhieta commented Feb 6, 2024

Description

Currently we mark permit back to DRAFT-state after 15 minutes of order creation. Introduce a new permit state CANCELLED and use that instead. With this update, each over 15 minutes old order and permit will get cancelled (not completely deleted) and the end-user can start permit and order creation from the beginning without any existing permit draft states (new permit and new order will be created)

Context

PV-784

How Has This Been Tested?

Manually through Webshop Talpa order cancellation process and through Admin UI.

danjacob-anders
danjacob-anders previously approved these changes Feb 6, 2024
Copy link
Contributor

@danjacob-anders danjacob-anders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
60.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mhieta mhieta merged commit 453dcb3 into develop Feb 6, 2024
4 checks passed
@mhieta mhieta deleted the PV-784-permit-cancelled-status branch February 6, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants