-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple refunds per order #411
Conversation
157ef68
to
970561f
Compare
970561f
to
44ae0c8
Compare
Codecov Report
@@ Coverage Diff @@
## develop #411 +/- ##
===========================================
- Coverage 81.21% 81.15% -0.07%
===========================================
Files 149 150 +1
Lines 8903 8899 -4
===========================================
- Hits 7231 7222 -9
- Misses 1672 1677 +5
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
44ae0c8
to
2e4735e
Compare
1. Adds "permits" M:M relationship to Refund 2. Make Order a 1:M field instead of 1:1 Permits should be added to refund as appropriate, e.g. a single permit when ending a permit, or all order permits in other cases. Refs: PV-684
2e4735e
to
dfd8609
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Description
Two changes to Refund model:
Context
PV-684
How Has This Been Tested?
Regression testing, tested manually