Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple refunds per order #411

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

danjacob-anders
Copy link
Contributor

@danjacob-anders danjacob-anders commented Nov 1, 2023

Description

Two changes to Refund model:

  1. Make order a 1:M relation rather than 1:1
  2. Add Permits field for adding permit info to Refund

Context

PV-684

How Has This Been Tested?

Regression testing, tested manually

@danjacob-anders danjacob-anders temporarily deployed to test November 1, 2023 13:04 — with GitHub Actions Inactive
@danjacob-anders danjacob-anders force-pushed the PV-684-multiple-refunds-per-order branch from 157ef68 to 970561f Compare November 1, 2023 13:23
@danjacob-anders danjacob-anders temporarily deployed to test November 1, 2023 13:23 — with GitHub Actions Inactive
@danjacob-anders danjacob-anders force-pushed the PV-684-multiple-refunds-per-order branch from 970561f to 44ae0c8 Compare November 1, 2023 13:25
@danjacob-anders danjacob-anders temporarily deployed to test November 1, 2023 13:25 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

Merging #411 (dfd8609) into develop (b6ad090) will decrease coverage by 0.07%.
Report is 1 commits behind head on develop.
The diff coverage is 71.42%.

@@             Coverage Diff             @@
##           develop     #411      +/-   ##
===========================================
- Coverage    81.21%   81.15%   -0.07%     
===========================================
  Files          149      150       +1     
  Lines         8903     8899       -4     
===========================================
- Hits          7231     7222       -9     
- Misses        1672     1677       +5     
Files Coverage Δ
parking_permits/admin.py 96.93% <100.00%> (+0.03%) ⬆️
...migrations/0042_add_permits_and_order_to_refund.py 100.00% <100.00%> (ø)
parking_permits/models/order.py 72.67% <100.00%> (+0.07%) ⬆️
parking_permits/models/refund.py 100.00% <100.00%> (ø)
parking_permits/customer_permit.py 72.22% <0.00%> (-0.23%) ⬇️
parking_permits/resolvers.py 55.66% <50.00%> (-0.04%) ⬇️
parking_permits/admin_resolvers.py 37.57% <0.00%> (-0.10%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@danjacob-anders danjacob-anders force-pushed the PV-684-multiple-refunds-per-order branch from 44ae0c8 to 2e4735e Compare November 1, 2023 13:26
@danjacob-anders danjacob-anders temporarily deployed to test November 1, 2023 13:26 — with GitHub Actions Inactive
1. Adds "permits" M:M relationship to Refund
2. Make Order a 1:M field instead of 1:1

Permits should be added to refund as appropriate, e.g. a single permit
when ending a permit, or all order permits in other cases.

Refs: PV-684
@danjacob-anders danjacob-anders force-pushed the PV-684-multiple-refunds-per-order branch from 2e4735e to dfd8609 Compare November 1, 2023 13:31
@danjacob-anders danjacob-anders temporarily deployed to test November 1, 2023 13:31 — with GitHub Actions Inactive
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

71.4% 71.4% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@mhieta mhieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@danjacob-anders danjacob-anders merged commit a9fbd91 into develop Nov 1, 2023
@danjacob-anders danjacob-anders deleted the PV-684-multiple-refunds-per-order branch November 1, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants