Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Traficom checks from PASI CSV-import #410

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

mhieta
Copy link
Collaborator

@mhieta mhieta commented Oct 31, 2023

Description

Remove Traficom checks from PASI CSV-import.

According to the latest specification, we do not need to validate PASI-permit vehicles against the Traficom API. Instead, we just use the vehicle registration number to create vehicles.

Context

PV-628

How Has This Been Tested?

With unit tests.

@mhieta mhieta temporarily deployed to test October 31, 2023 10:49 — with GitHub Actions Inactive
@mhieta mhieta force-pushed the PV-628-csv-import-remove-traficom branch from 1dab7ee to e0b377e Compare October 31, 2023 12:59
@mhieta mhieta temporarily deployed to test October 31, 2023 12:59 — with GitHub Actions Inactive
Copy link
Contributor

@danjacob-anders danjacob-anders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@mhieta mhieta merged commit 785ba69 into develop Oct 31, 2023
5 checks passed
@mhieta mhieta deleted the PV-628-csv-import-remove-traficom branch October 31, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants