Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(release-4.0.0) Improve cookie consent docs #1433

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

NikoHelle
Copy link
Contributor

Description

Better docs for mainly non-React use.

How Has This Been Tested?

Demos:

Links to demos are in the comments

Screenshots (if appropriate):

Add to changelog

  • no need.

Copy link

Preview found from hds-demo docs/preview_1433

Demos

Docs
Core Storybook
React Storybook

Copy link

github-actions bot commented Nov 20, 2024

Test Results

  1 files   64 suites   11m 48s ⏱️
 60 tests  60 ✅ 0 💤 0 ❌
120 runs  120 ✅ 0 💤 0 ❌

Results for commit 8ffbb97.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@mrTuomoK mrTuomoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor

@laurakarhu laurakarhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@NikoHelle NikoHelle merged commit a7f4bb2 into release-4.0.0 Nov 21, 2024
8 checks passed
@NikoHelle NikoHelle deleted the v4-cookie-clean branch November 21, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants