HDS-2155 table class fix #1236
Merged
HDS-2155 table class fix #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikoHelle
requested changes
Mar 4, 2024
CHANGELOG.md
Outdated
| @@ -24,6 +24,7 @@ Changes that are not related to specific components | |||
| - Removed old & deprecated individual `lodash` dependencies and replaced with the full package and importing the needed functions only. | |||
| - [HeaderActionBarItemWithDropdown] Removed useless `@layer` css style which caused Jest/jsdom tests output errors. | |||
| - [Checkbox] Layout issue when using external label with htmlLabelFor-attribute | |||
| - [Table] className prop overring the default class | |||
There was a problem hiding this comment.
Perhaps: "ClassName prop is appended to HDS classNames instead of overriding all classNames."
mrTuomoK
force-pushed
the
HDS-2155-table-class-fix
branch
from
61a14ae
to
6872dda
Compare
mrTuomoK
force-pushed
the
HDS-2155-table-class-fix
branch
from
6872dda
to
717a64d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment all default class names are overridden when using Table component
classNameprop. The reason for this is the{...rest}statement after all the props in the TableContainer component. TheclassNameprop is added to the class names to solve this issue.{...rest}is also moved before other props to avoid other default props to be overridden as well.Related Issue
HDS-2155
Motivation and Context
Motivation for this PR is to support className prop in the Table component. This can be used to add some minor tweaks for the default styles. Other reason for this PR is to avoid unexpected behaviour when using className prop.
How Has This Been Tested?
Add to changelog