Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(HDS-2142) fix checkbox layout issue #1228

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

mrTuomoK
Copy link
Contributor

@mrTuomoK mrTuomoK commented Feb 15, 2024

Description

The Checkbox layout was again broken when using external label with htmlLabelFor-attribute.

  • fix checkbox layout issue
  • add story for external label
  • update reference images

Related Issue

HDS-2142

How Has This Been Tested?

  • local machine, visual tests

Add to changelog

  • Added needed line to changelog

@mrTuomoK mrTuomoK requested a review from a team February 15, 2024 06:59
@NikoHelle
Copy link
Contributor

Is this an issue with RadioButton too and if so, this should be applied there too?

@laurakarhu laurakarhu requested a review from a team February 21, 2024 12:01
Copy link
Contributor

@NikoHelle NikoHelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one comment about h3

@NikoHelle
Copy link
Contributor

FYI: Radiobutton with same story works out of the box:

image

@mrTuomoK mrTuomoK force-pushed the HDS-2142-checkbox-no-label-layout-fix branch from c9dfa3c to 6570b7f Compare February 23, 2024 11:26
@mrTuomoK mrTuomoK merged commit 7cbae42 into development Feb 23, 2024
6 checks passed
@mrTuomoK mrTuomoK deleted the HDS-2142-checkbox-no-label-layout-fix branch February 23, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants