Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --use-pep517 flag in pip install #342

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

danipran
Copy link
Contributor

@danipran danipran commented Mar 9, 2023

Description

Add --use-pep517 flag in pip install command.

Motivation and Context

Due to warnings such as this:

DEPRECATION: psycopg2 is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at pypa/pip#8559

This also seems to be coming sooner than later (2023 Spring at the time of writing).

Additional notes

From what I understand, this seems to be the way to go until the source package gets updated. The only other option is to pin an older pip version instead.

We'll see what future brings, I suppose ¯\(ツ)

Related discussions I scanned through:
pypa/pip#8368
pypa/pip#8559
pypa/pip#8102

Due to warnings such as this:
DEPRECATION: psycopg2 is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at pypa/pip#8559
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #342 (083651d) into develop (ccec13c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #342   +/-   ##
========================================
  Coverage    93.89%   93.89%           
========================================
  Files          149      149           
  Lines         5467     5467           
========================================
  Hits          5133     5133           
  Misses         334      334           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@danipran danipran marked this pull request as ready for review March 9, 2023 12:58
@danipran danipran requested a review from voneiden March 9, 2023 12:58
Copy link
Contributor

@voneiden voneiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll put a note on the calendar to re-check the need for this in 2032 AD

@danipran danipran merged commit 353e493 into develop Mar 9, 2023
@danipran danipran deleted the fix-ci-add-use-pep517-flag-in-pip branch March 9, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants