UHF-5512: Add highlight connection support for TPR Units #122

tapsal · 2022-05-20T06:14:15Z

Add highlight connection support UHF-5512

Import Highlight connections so that they can be used with unit contact cards.

What was done

Added Highlight field to TPR Units.
Added Highlight connection.
Import highlight connections to the new highlight field.
- Also needed to change how the Opening hours connections are imported at the migration config. When the highlight connection was added to the connection repository, the connections source includes both opening hours and hightlights, and this caused the skip_on_value process to skip unit rows.

How to install

Make sure your instance is up and running on latest dev branch.
Update the Helfi TPR module:
- composer require drupal/helfi_tpr:dev-UHF-5512-tpr-unit-highlights
Run make drush-updb
Run make drush-cr

How to test

Run make shell and the import TPR units:
- drush migrate:import tpr_unit
The other PR can be used to check that the highlights are imported by viewing them with unit contact cards.

Other PRs

UHF-5512: Sote unit contact card drupal-helfi-sote#380

codecov-commenter · 2022-05-20T12:16:01Z

Codecov Report

Merging #122 (edce5ea) into main (35657ba) will increase coverage by 0.35%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #122      +/-   ##
============================================
+ Coverage     73.22%   73.58%   +0.35%     
- Complexity      294      306      +12     
============================================
  Files            40       42       +2     
  Lines          1072     1094      +22     
============================================
+ Hits            785      805      +20     
- Misses          287      289       +2

Impacted Files	Coverage Δ
...trib/helfi_tpr/src/Field/Connection/Repository.php	`85.71% <0.00%> (ø)`
.../src/Plugin/migrate/process/ArrayElementEquals.php	`84.61% <0.00%> (ø)`
...ntrib/helfi_tpr/src/Field/Connection/Highlight.php	`100.00% <0.00%> (ø)`
modules/contrib/helfi_tpr/src/Entity/Unit.php	`92.42% <0.00%> (+0.29%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35657ba...edce5ea. Read the comment docs.