-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-10719: Upgrade drupal/elasticsearch_connector major version #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elasticsearch connector v8 no longer includes boost parameter by default: https://git.drupalcode.org/project/elasticsearch_connector/-/blob/8.0.x/src/SearchAPI/FieldMapper.php#L112
Elasticsearch connector natively supports geo_point. See: https://git.drupalcode.org/project/elasticsearch_connector/-/blob/8.0.x/src/SearchAPI/FieldMapper.php?ref_type=heads#L136
This was referenced Nov 4, 2024
hyrsky
force-pushed
the
UHF-10719-es-errors
branch
from
November 4, 2024 07:02
6a804c1
to
f7e9de3
Compare
Quality Gate passedIssues Measures |
This was referenced Nov 4, 2024
hyrsky
commented
Nov 4, 2024
rpnykanen
approved these changes
Nov 4, 2024
rpnykanen
approved these changes
Nov 4, 2024
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-10719
What was done
We have had no visibility into Elasticsearch errors, and our current system does not raise any alarms if Elasticsearch goes down.
I have been looking into ways to improve this, and I believe that updating the elasticsearch_connector module is the best solution. The v7 version currently in use only displays messages with \Drupal::messenger() on errors. The next major version has much better error handling. In v8, all exceptions are logged, which raises Sentry errors as of UHF-10844.
Major changes
ruflin/elastica
. I added this tohelfi_platform_config
'scomposer.json
, so that the update would work. This can be removed later, since it is actually not used anywhere._language
was removed. See hdbt PR for related changes.How to install
git pull origin dev
make fresh
git checkout UHF-10719-es-errors
composer require drupal/helfi_platform_config:dev-UHF-10719-es-errors drupal/hdbt:dev-UHF-10719-es-errors -W
drush deploy
How to test
drush sapi-rt; drush sapi-c; drush sapi-i
Continuous documentation
Translations
Other PRs