Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8099: Field group patch #478

Merged
merged 4 commits into from
Mar 28, 2023
Merged

UHF-8099: Field group patch #478

merged 4 commits into from
Mar 28, 2023

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Mar 28, 2023

UHF-8099

What was done

  • Removed patch for field_group translations and added missing translations to configuration

Notice: Test on etusivu instance

How to install

  • Make sure your Etusivu instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8099 -W
  • Run make drush-updb drush-cr

How to test

  • Log in and go to admin page to change the administration pages language to Finnish -> https://helfi-etusivu.docker.so/en/user/1/edit
  • Go and create a news item and check that the "Main image" and "Links" field groups are translated to Finnish; "Pääkuva" and "Linkit". See pictures below
    image
    image

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants