Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-8217: Remove the generator tag from DOM #477

Merged
merged 1 commit into from
Mar 29, 2023
Merged

UHF-8217: Remove the generator tag from DOM #477

merged 1 commit into from
Mar 29, 2023
+11 −0

Conversation

dire
Copy link
Contributor

@dire dire commented Mar 28, 2023 •
edited by jira bot
Loading

UHF-8217

Generator info is visible in the DOM.

What was done

  • Removed the generator metatag from the DOM by altering the html head.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8217_Remove-generator-info
  • Run make drush-cr

How to test

  • Check that the Generator metatag is not anymore in the DOM.

@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

tuutti
tuutti approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@tuutti tuutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dire dire merged commit 1195bdf into 3.x Mar 29, 2023
@dire dire deleted the UHF-8217_Remove-generator-info branch March 29, 2023 06:50
This was referenced Mar 31, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuutti tuutti tuutti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dire @tuutti