Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10771 #756

Open
wants to merge 25 commits into
base: dev
Choose a base branch
from
Open

UHF-10771 #756

wants to merge 25 commits into from

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Nov 14, 2024

UHF-10771

Add new "Helsinki near you" pages and components

What was done

  • Added controllers for helsinki near you landing and results pages
  • Added components to calculate coordinates based on user address input

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10771
  • Change hdbt and helfi_platform_config to correct branches:
    • composer require drupal/hdbt:dev-UHF-10771
    • composer require drupal/helfi_platform_config:dev-UHF-10771
  • make fresh
  • Run make drush-cr drush-updb

How to test

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

Copy link

sonarcloud bot commented Nov 14, 2024

@jeremysteerio jeremysteerio marked this pull request as ready for review November 26, 2024 04:47
$return_url = Url::fromRoute('helfi_etusivu.helsinki_near_you');

if (!$address) {
$this->messenger->addMessage($this->t('Please enter an address', [], ['context' => 'Helsinki near you']), 'error');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use $this->messenger().

);

if (!$addressData) {
$this->messenger->addMessage($this->t('Address not found', [], ['context' => 'Helsinki near you']), 'error');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use $this->messenger().

Drupal\helfi_etusivu\Token\NewsNodeImageBuilder:
class: Drupal\helfi_etusivu\Token\NewsNodeImageBuilder
tags:
- { name: helfi_platform_config.og_image_builder }
Drupal\helfi_etusivu\Servicemap: ~
Drupal\helfi_etusivu\Controller\HelsinkiNearYouResultsController: ~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Controllers don't need to be declared in services.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants