-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-10771 #756
base: dev
Are you sure you want to change the base?
UHF-10771 #756
Conversation
…and moved elements to the route, removed unnecessary code
…-results and -landing pages, moved translations
Quality Gate passedIssues Measures |
$return_url = Url::fromRoute('helfi_etusivu.helsinki_near_you'); | ||
|
||
if (!$address) { | ||
$this->messenger->addMessage($this->t('Please enter an address', [], ['context' => 'Helsinki near you']), 'error'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use $this->messenger()
.
); | ||
|
||
if (!$addressData) { | ||
$this->messenger->addMessage($this->t('Address not found', [], ['context' => 'Helsinki near you']), 'error'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use $this->messenger()
.
Drupal\helfi_etusivu\Token\NewsNodeImageBuilder: | ||
class: Drupal\helfi_etusivu\Token\NewsNodeImageBuilder | ||
tags: | ||
- { name: helfi_platform_config.og_image_builder } | ||
Drupal\helfi_etusivu\Servicemap: ~ | ||
Drupal\helfi_etusivu\Controller\HelsinkiNearYouResultsController: ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Controllers don't need to be declared in services.yml
.
UHF-10771
Add new "Helsinki near you" pages and components
What was done
How to install
git checkout UHF-10771
composer require drupal/hdbt:dev-UHF-10771
composer require drupal/helfi_platform_config:dev-UHF-10771
make fresh
make drush-cr drush-updb
How to test
Continuous documentation
Translations
Other PRs