Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8242: Workaround map limits #614

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Conversation

jeremysteerio
Copy link
Contributor

@jeremysteerio jeremysteerio commented Mar 31, 2023

UHF-8242

Prevent map from breaking when search yields too much results.

What was done

  • Move map to its own component
  • Query palvelukartta directly if result count is too high

How to install

How to test

  • Edit or create a landing page to include a school search paragraph
  • View the page. Click on Show results as a map -button on the right top corner of the results
  • The map should load all the schools. This might take a few seconds.

@jeremysteerio jeremysteerio force-pushed the UHF-8242-workaround-map-limits branch from 6c78dc1 to 4953f6e Compare April 3, 2023 06:51
@Jussiles Jussiles self-requested a review April 3, 2023 09:16
Copy link
Contributor

@Jussiles Jussiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants