Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X accordion state fix & accessibility fix #583

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Mar 15, 2023

What was done

  • Fixed problem which prevented accordion from working on multiple pages
  • Added type attribute to button-html element due to accessibility guidelines

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_accordion_state_fix
  • Run make drush-cr

How to test

  • Open and close accordion items on multiple pages
  • Reload the pages after opening and closing accordions
    • Accordion items should open and close on page load
    • No javascript errors on inspector while opening and closing the accordion items after page reload
  • Accordion toggle & close buttons have type="button" -attribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants