Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-7896: Update GIN to 3.0.0-rc2 #206

Merged
merged 4 commits into from
Apr 4, 2023
Merged

UHF-7896: Update GIN to 3.0.0-rc2 #206

merged 4 commits into from
Apr 4, 2023

Conversation

Jussiles
Copy link
Contributor

@Jussiles Jussiles commented Mar 31, 2023 •
edited by khalima
Loading

UHF-7896

What was done

  • Update GIN to 3.0.0-rc2 and add some small tweaks

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT Admin theme
    • composer require drupal/hdbt_admin:dev-UHF-7896-update-gin
    • Check that new version of GIN is installed. If not, run composer install
  • Run make drush-cr

How to test

  • Check that admin theme works: (node) forms, adding and editing paragraphs, media browser, content overview page, tables, buttons...
  • Check that custom css tweaks are ok
  • Check that code follows our standards

khalima
khalima approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Kasko and Etusivu. Works nicely! 🚀

@Jussiles Jussiles merged commit 2904d82 into 2.x Apr 4, 2023
@Jussiles Jussiles deleted the UHF-7896-update-gin branch April 4, 2023 06:26
This was referenced Apr 4, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jussiles @khalima