Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add minHealth which controls when carbons die so we can set it in species #6938

Merged
merged 5 commits into from
Dec 31, 2024

Conversation

timothyteakettle
Copy link
Contributor

About The Pull Request

adds support for controlling the speed point at which crabs carbons die
required for holospheres because their hologram form has very low health which isn't possible if they die at -100

this is set in mob/living because that's where maxHealth is currently handled but right now only carbons care about minHealth because everything else ignores the old config option and dies at 0

changes are replicated to also store crit and softcrit thresholds

Why It's Good For The Game

better control over the point at which things die

Changelog

🆑
add: add minHealth which controls when carbons die so we can set it in species
/:cl:

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 24, 2024
TheLordME
TheLordME previously approved these changes Dec 29, 2024
Copy link
Collaborator

@TheLordME TheLordME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can crithealth not be set via species? if I set my minimum health higher than the crit health I never go into crit, which might be intentional at times, but also unintention at other times

silicons pushed a commit that referenced this pull request Dec 29, 2024
silicons pushed a commit that referenced this pull request Dec 29, 2024
silicons pushed a commit that referenced this pull request Dec 30, 2024
@TheLordME TheLordME merged commit faa992a into Citadel-Station-13:master Dec 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants