Skip to content

reagent holder rework #19558

reagent holder rework

reagent holder rework #19558

Triggered via pull request December 22, 2024 00:10
Status Failure
Total duration 2m 16s
Artifacts

ci_suite.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

14 errors and 12 warnings
Compile Maps
Process completed with exit code 1.
Integration Tests
Process completed with exit code 1.
Run Linters: code/modules/mob/living/carbon/blood_holder.dm#L96
undefined var: "checking"
Run Linters: code/modules/reagents/chemistry/reactions/paint.dm#L89
undefined proc: "get_data" on /datum/reagent_holder
Run Linters: code/game/objects/effects/chem/foam.dm#L113
undefined field: "reagent_list" on /datum/reagent_holder
Run Linters: code/game/objects/effects/chem/chemsmoke.dm#L102
undefined field: "reagent_list" on /datum/reagent_holder
Run Linters: code/game/objects/effects/chem/chemsmoke.dm#L104
undefined proc: "touch_turf" on /datum/reagent_holder
Run Linters: code/game/objects/effects/chem/chemsmoke.dm#L106
undefined proc: "touch_turf" on /datum/reagent_holder
Run Linters: code/game/objects/effects/chem/chemsmoke.dm#L111
undefined proc: "touch_obj" on /datum/reagent_holder
Run Linters: code/game/objects/effects/chem/chemsmoke.dm#L160
undefined field: "reagent_list" on /datum/reagent_holder
Run Linters: code/modules/power/singularity/particle_accelerator/particle_smasher.dm#L291
undefined field: "reagent_list" on /datum/reagent_holder
Run Linters: code/modules/reagents/chemistry/reagents/core/acid.dm#L23
undefined proc: "remove_self" on /datum/reagent/acid
Windows Build
Process completed with exit code 1.
Completion Gate
Process completed with exit code 1.
Start Gate
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Integration Tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Run Linters: code/modules/food/food/snacks.dm#L19
#warn ohhh no
Run Linters: code/modules/mob/living/carbon/blood_holder.dm#L50
#warn impl; check for host blood
Run Linters: code/modules/mob/living/carbon/blood_holder.dm#L65
#warn impl; scaling will be a pain here
Run Linters: code/modules/mob/living/carbon/blood_holder.dm#L162
#warn impl fragments self/others, amounts
Run Linters: code/modules/mob/living/carbon/blood_holder.dm#L165
#warn how to handle color? compute_color_from_data, don't forget!
Run Linters: code/modules/mob/living/carbon/carbon-blood.dm#L24
#warn erase all others, combine volumes