Updates to the multi-version fonction and 'contract.js' ruleset #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ObjectIsAdvantag
commented
Oct 3, 2024
ObjectIsAdvantag
commented
- improved regexp to support corner cases, see https://app.asana.com/0/1206872740398257/1206657704786474/f
- added an exception list for paths that include version numbers by design such as Meraki 'dhcp/v4'
- simplified name of rule 'multi-versions-server-url-missing-version]' to 'server-url-missing-version'
- simplifications, clarifications and more consistent spectral messages
|
hum, the CI tests seems to be failing :-( FYI, I had checked that the Meraki, Catalyst SD-WAN, Catalyst Center and Crosswork documents are analyzed correctly using the updated Contract ruleset. |
…hts, added changelog, passes CI tests
|
final PR scope:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.