Trying resolving issue with meraki_mx_content_filtering #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y0rune
force-pushed
the
issue-with-mx_content_filtering
branch
from
f608fd2 to
bf001e0
Compare
|
Please split the bug fix into its own PR since it's separate from the cleanup. However thanks for the bug fix! |
|
Yeah yeah, when the PR will be final I will remove the commit with clean up the test ;) |
y0rune
force-pushed
the
issue-with-mx_content_filtering
branch
from
6d1d59f to
799c2d4
Compare
When the code has the only the `generate_diff`. That function does not handle the NoneType for the agrs. So I think it will be better to handle it via is statement `if recursive_diff is None`.
y0rune
force-pushed
the
issue-with-mx_content_filtering
branch
from
bc9f328 to
85c26d7
Compare
y0rune
force-pushed
the
issue-with-mx_content_filtering
branch
from
85c26d7 to
e35ecd7
Compare
|
I resolved the issue in the that PR. If somebody would like to test it, please copy the newer tests from #406. |
kbreit
reviewed
Jan 22, 2023
|
Looks good. Thank you for your contribution. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issue with empty params (when it was resetting)