Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved warnings in meraki_ms_stack #402

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Resolved warnings in meraki_ms_stack #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
574e8ab
Resolved warnings in meraki_ms_stack
y0rune Dec 30, 2022
7a9c610
Added the changelog
y0rune Dec 30, 2022
ce8aebb
Resolved warnings with fqdn. Changed the meraki_switch_stack to cisco…
y0rune Dec 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/warnings-meraki_ms_stack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
trivial:
- Resolved ansible-lint warnings in tests for module-meraki_ms_stack
161 changes: 89 additions & 72 deletions tests/integration/targets/meraki_ms_stack/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,27 +3,29 @@

# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
---
- block:
- name: Block of tests
block:
- name: Create network with type switch
meraki_network:
cisco.meraki.meraki_network:
auth_key: '{{ auth_key }}'
state: present
org_name: '{{test_org_name}}'
net_name: '{{test_switch_net_name}}'
org_name: '{{ test_org_name }}'
net_name: '{{ test_switch_net_name }}'
type: switch
timezone: America/Chicago
delegate_to: localhost
register: create_net_switch

- set_fact:
net_id: '{{create_net_switch.data.id}}'
- name: Set fact create_net_switch
ansible.builtin.set_fact:
net_id: '{{ create_net_switch.data.id }}'

- name: Claim devices into network
meraki_device:
auth_key: '{{auth_key}}'
org_name: '{{test_org_name}}'
net_id: '{{net_id}}'
serial: '{{item}}'
cisco.meraki.meraki_device:
auth_key: '{{ auth_key }}'
org_name: '{{ test_org_name }}'
net_id: '{{ net_id }}'
serial: '{{ item }}'
state: present
delegate_to: localhost
register: claim_device
Expand All @@ -33,166 +35,181 @@
- "QBSB-D75G-PXCG"

- name: Create new stack
meraki_switch_stack:
cisco.meraki.meraki_ms_stack:
auth_key: '{{ auth_key }}'
state: present
org_name: '{{test_org_name}}'
net_name: '{{test_switch_net_name}}'
org_name: '{{ test_org_name }}'
net_name: '{{ test_switch_net_name }}'
name: Test stack
serials:
- "QBSB-BPR6-PRER"
- "QBSB-VLNE-E299"
register: create

- debug:
- name: Debug create
ansible.builtin.debug:
var: create

- set_fact:
stack_id: '{{create.data.id}}'
- name: Set fact create
ansible.builtin.set_fact:
stack_id: '{{ create.data.id }}'

- assert:
- name: Assert create
ansible.builtin.assert:
that:
- create.data is defined
- create is changed

- name: Add switch to stack
meraki_switch_stack:
cisco.meraki.meraki_ms_stack:
auth_key: '{{ auth_key }}'
state: present
org_name: '{{test_org_name}}'
net_name: '{{test_switch_net_name}}'
stack_id: '{{stack_id}}'
org_name: '{{ test_org_name }}'
net_name: '{{ test_switch_net_name }}'
stack_id: '{{ stack_id }}'
serials:
- "QBSB-D75G-PXCG"
register: add_stack

- assert:
- name: Assert add_stack
ansible.builtin.assert:
that:
- add_stack.data is defined
- add_stack.data.serials | length == 3
- add_stack is changed

- name: Add switch to stack idempotent
meraki_switch_stack:
cisco.meraki.meraki_ms_stack:
auth_key: '{{ auth_key }}'
state: present
org_name: '{{test_org_name}}'
net_name: '{{test_switch_net_name}}'
stack_id: '{{stack_id}}'
org_name: '{{ test_org_name }}'
net_name: '{{ test_switch_net_name }}'
stack_id: '{{ stack_id }}'
serials:
- "QBSB-D75G-PXCG"
register: add_stack_idempotent

- assert:
- name: Assert add_stack_idempotent
ansible.builtin.assert:
that:
- add_stack_idempotent.data is defined
- add_stack_idempotent.data.serials | length == 3
- add_stack_idempotent is not changed

- name: Remove switch from stack
meraki_switch_stack:
cisco.meraki.meraki_ms_stack:
auth_key: '{{ auth_key }}'
state: absent
org_name: '{{test_org_name}}'
net_name: '{{test_switch_net_name}}'
stack_id: '{{stack_id}}'
org_name: '{{ test_org_name }}'
net_name: '{{ test_switch_net_name }}'
stack_id: '{{ stack_id }}'
serials:
- "QBSB-D75G-PXCG"
register: remove_from_stack

- debug:
- name: Debug remove_from_stack
ansible.builtin.debug:
var: remove_from_stack

- assert:
- name: Assert remove_from_stack
ansible.builtin.assert:
that:
- remove_from_stack.data is defined
- remove_from_stack.data.serials | length == 2
- remove_from_stack is changed

- name: Remove switch from stack idempotent
meraki_switch_stack:
cisco.meraki.meraki_ms_stack:
auth_key: '{{ auth_key }}'
state: absent
org_name: '{{test_org_name}}'
net_name: '{{test_switch_net_name}}'
stack_id: '{{stack_id}}'
org_name: '{{ test_org_name }}'
net_name: '{{ test_switch_net_name }}'
stack_id: '{{ stack_id }}'
serials:
- "QBSB-D75G-PXCG"
register: remove_from_stack_idempotent

- debug:
- name: Debug remove_from_stack_idempotent
ansible.builtin.debug:
var: remove_from_stack_idempotent

- assert:
- name: Assert remove_from_stack_idempotent
ansible.builtin.assert:
that:
- remove_from_stack_idempotent.data is defined
- remove_from_stack_idempotent.data.serials | length == 2
- remove_from_stack_idempotent is not changed

- name: Query all stacks in the network
meraki_switch_stack:
cisco.meraki.meraki_ms_stack:
auth_key: '{{ auth_key }}'
state: query
org_name: '{{test_org_name}}'
net_name: '{{test_switch_net_name}}'
org_name: '{{ test_org_name }}'
net_name: '{{ test_switch_net_name }}'
register: query_all

- debug:
- name: Debug query_all
ansible.builtin.debug:
var: query_all

- assert:
- name: Assert query_all
ansible.builtin.assert:
that:
- query_all.data is defined
- query_all is not changed

- name: Query one stack
meraki_switch_stack:
cisco.meraki.meraki_ms_stack:
auth_key: '{{ auth_key }}'
state: query
org_name: '{{test_org_name}}'
net_name: '{{test_switch_net_name}}'
stack_id: '{{stack_id}}'
org_name: '{{ test_org_name }}'
net_name: '{{ test_switch_net_name }}'
stack_id: '{{ stack_id }}'
register: query_one

- debug:
- name: Debug query_one
ansible.builtin.debug:
var: query_one

- assert:
- name: Assert query_one
ansible.builtin.assert:
that:
- query_one.data is defined
- query_one is not changed

- name: Query one stack using name
meraki_switch_stack:
cisco.meraki.meraki_ms_stack:
auth_key: '{{ auth_key }}'
state: query
org_name: '{{test_org_name}}'
net_name: '{{test_switch_net_name}}'
org_name: '{{ test_org_name }}'
net_name: '{{ test_switch_net_name }}'
name: Test stack
register: query_one_name

- debug:
- name: Debug query_one_name
ansible.builtin.debug:
var: query_one_name

- assert:
- name: Assert query_one_name
ansible.builtin.assert:
that:
- query_one_name.data is defined
- query_one_name is not changed

always:
- name: Delete stack
meraki_switch_stack:
auth_key: '{{ auth_key }}'
state: absent
org_name: '{{test_org_name}}'
net_name: '{{test_switch_net_name}}'
stack_id: '{{stack_id}}'
register: delete

- name: Delete network
meraki_network:
auth_key: '{{ auth_key }}'
state: absent
org_name: '{{test_org_name}}'
net_name: '{{test_switch_net_name}}'
delegate_to: localhost
- name: Delete stack
cisco.meraki.meraki_ms_stack:
auth_key: '{{ auth_key }}'
state: absent
org_name: '{{ test_org_name }}'
net_name: '{{ test_switch_net_name }}'
stack_id: '{{ stack_id }}'
register: delete

- name: Delete network
cisco.meraki.meraki_network:
auth_key: '{{ auth_key }}'
state: absent
org_name: '{{ test_org_name }}'
net_name: '{{ test_switch_net_name }}'
delegate_to: localhost