-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue with default values for ssl, proxy, timeout in 'aci.py' and the display of host in the url when the plugin 'httpapi' is used #475
Conversation
…t in 'aci.py' and the display of host in the url when the plugin 'httpapi' is used
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #475 +/- ##
===========================================
+ Coverage 35.51% 96.54% +61.02%
===========================================
Files 181 183 +2
Lines 8308 8457 +149
Branches 1225 1258 +33
===========================================
+ Hits 2951 8165 +5214
+ Misses 5357 221 -5136
- Partials 0 71 +71
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…correctly populated when http status is not 200
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…w parsed by response_xml function in aci.py when status is not 200
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.