Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with default values for ssl, proxy, timeout in 'aci.py' and the display of host in the url when the plugin 'httpapi' is used #475

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

shrsr
Copy link
Collaborator

@shrsr shrsr commented Sep 8, 2023

No description provided.

…t in 'aci.py' and the display of host in the url when the plugin 'httpapi' is used
@shrsr shrsr self-assigned this Sep 8, 2023
@shrsr shrsr requested review from akinross, sajagana, lhercot, anvitha-jain and gmicol and removed request for akinross and sajagana September 8, 2023 16:40
@shrsr shrsr linked an issue Sep 8, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 96.91% and project coverage change: +61.02% 🎉

Comparison is base (dbedc62) 35.51% compared to head (c2aaf2b) 96.54%.
Report is 9 commits behind head on master.

❗ Current head c2aaf2b differs from pull request most recent head 1b3e23b. Consider uploading reports for the commit 1b3e23b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #475       +/-   ##
===========================================
+ Coverage   35.51%   96.54%   +61.02%     
===========================================
  Files         181      183        +2     
  Lines        8308     8457      +149     
  Branches     1225     1258       +33     
===========================================
+ Hits         2951     8165     +5214     
+ Misses       5357      221     -5136     
- Partials        0       71       +71     
Flag Coverage Δ
integration 94.55% <95.67%> (?)
sanity 35.24% <20.98%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plugins/modules/aci_config_rollback.py 91.42% <66.66%> (+58.09%) ⬆️
.../modules/aci_interface_policy_leaf_policy_group.py 98.94% <97.14%> (+72.28%) ⬆️
...dules/aci_interface_policy_leaf_fc_policy_group.py 97.91% <97.91%> (ø)
plugins/httpapi/aci.py 94.29% <100.00%> (+76.23%) ⬆️
plugins/module_utils/aci.py 74.81% <100.00%> (+63.40%) ⬆️
...modules/aci_interface_policy_spine_policy_group.py 100.00% <100.00%> (ø)
plugins/modules/aci_l3out_extepg.py 100.00% <100.00%> (+54.54%) ⬆️

... and 171 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

anvitha-jain
anvitha-jain previously approved these changes Sep 8, 2023
akinross
akinross previously approved these changes Sep 8, 2023
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugins/module_utils/aci.py Outdated Show resolved Hide resolved
…correctly populated when http status is not 200
@shrsr shrsr dismissed stale reviews from akinross and anvitha-jain via d34f2b1 September 12, 2023 21:38
akinross
akinross previously approved these changes Sep 13, 2023
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…w parsed by response_xml function in aci.py when status is not 200
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 4cee5c5 into CiscoDevNet:master Sep 28, 2023
15 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aci_rest use_ssl is defaults to False
6 participants