Added subject label functionality to external EPGs #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrsr
requested changes
Aug 1, 2023
There was a problem hiding this comment.
@markciecior Please make the suggested changes so that I can approve your PR.
| # -*- coding: utf-8 -*- | ||
|
|
||
| # Copyright: (c) 2020, Sudhakar Shet Kudtarkar (@kudtarkar1) | ||
| # Copyright: (c) 2020, Shreyas Srish <[email protected]> |
There was a problem hiding this comment.
Please remove:
# Copyright: (c) 2020, Sudhakar Shet Kudtarkar (@kudtarkar1)
# Copyright: (c) 2020, Shreyas Srish <[email protected]>
| description: More information about the internal APIC class B(fvtenant), B(l3extInstP) and B(l3extOut). | ||
| link: https://developer.cisco.com/docs/apic-mim-ref/ | ||
| author: | ||
| - Sudhakar Shet Kudtarkar (@kudtarkar1) |
There was a problem hiding this comment.
Please remove the following and add your name:
- Sudhakar Shet Kudtarkar (@kudtarkar1)
- Shreyas Srish (@shrsr)
| @@ -4,6 +4,7 @@ lh-dmz1-pod3-sim-v42 ansible_host=173.36.219.68 aci_hostname=173.36.219.68 | |||
| lh-dmz1-pod3-sim-v51 ansible_host=173.36.219.129 aci_hostname=173.36.219.129 | |||
| aws_cloud ansible_host=52.52.20.121 aci_hostname=52.52.20.121 aci_password="sJ94G92#8dq2hx*K4qh" cloud_type=aws region=us-east-1 region_2=us-west-1 availability_zone=us-west-1a | |||
| azure_cloud ansible_host=104.42.26.226 aci_hostname=104.42.26.226 aci_password="sJ94G92#8dq2hx*K4qh" cloud_type=azure region=westus region_2=westus2 vnet_gateway=true | |||
| sandbox ansible_host=sandboxapicdc.cisco.com aci_hostname=sandboxapicdc.cisco.com aci_username=admin aci_password="!v3G@!4@Y" | |||
| - name: Verify bind_extepg_consumer_contract | ||
| assert: | ||
| that: | ||
| - bind_extepg_consumer_contract.msg == "state is present but all of the following are missing: contract_type" |
There was a problem hiding this comment.
- bind_extepg_consumer_contract.msg == "state is present but all of the following are missing: contract_type" this statement will fail the assertion. Can you please rectify?
| @@ -0,0 +1,129 @@ | |||
| # Test code for the ACI modules | |||
| # Copyright: (c) 2020, Shreyas Srish (@shrsr), Mark Ciecior (@markciecior) | |||
There was a problem hiding this comment.
Please remove: # Copyright: (c) 2020, Shreyas Srish (@shrsr),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.