Fixed clamonacc infinite loop when watch directory doesn't exist #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahsnyder
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
In testing this does indeed fix the bug and scanning of other valid include-paths do work after this change.
There is unfortunately no error or warning message when the OnAccessIncludePath does not exist. But no adverse effect either, now.
I played with it a tiny bit to try and put in a warning message. I was able to, but it didn't feel like the right spot and I wasn't sure if there would be adverse effects to that... so I think I wanna accept this as-is.
Juho-J
pushed a commit
to Juho-J/clamav
that referenced
this pull request
Mar 6, 2024
micahsnyder
pushed a commit
to Juho-J/clamav
that referenced
this pull request
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #793